WIP: Move conformance tests to a package extension #1954
+416
−347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/TestExt
branch
2 times, most recently
from
ecbefca to
8031e79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
- Coverage 88.21% 87.89% -0.33%
==========================================
Files 119 121 +2
Lines 30427 30580 +153
==========================================
+ Hits 26842 26877 +35
- Misses 3585 3703 +118 ☔ View full report in Codecov by Sentry. |
lgoettgens
force-pushed
the
lg/TestExt
branch
from
8031e79 to
1cd32fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1936.
This PR is currently just a convenient way for me to run the downstream tests, i.e. to check if the backwards compatibility stuff works as expected.